From e42805d51aa163343800600b6440a89f88f00dc4 Mon Sep 17 00:00:00 2001 From: Marios Makassikis Date: Tue, 8 Nov 2022 09:43:17 +0100 Subject: [PATCH 17/17] ksmbd-tools: mountd: check rpc_{lsarpc,samr}_init return value While here, add some missing checks in rpc_samr_init(). Signed-off-by: Marios Makassikis --- mountd/rpc.c | 6 ++++-- mountd/rpc_samr.c | 6 ++++-- 2 files changed, 8 insertions(+), 4 deletions(-) diff --git a/mountd/rpc.c b/mountd/rpc.c index 4e0e78fdf5a9..f9b71fb60271 100644 --- a/mountd/rpc.c +++ b/mountd/rpc.c @@ -743,8 +743,10 @@ int rpc_init(void) if (!pipes_table) return -ENOMEM; g_rw_lock_init(&pipes_table_lock); - rpc_samr_init(); - rpc_lsarpc_init(); + if (rpc_samr_init()) + return -ENOMEM; + if (rpc_lsarpc_init()) + return -ENOMEM; return 0; } diff --git a/mountd/rpc_samr.c b/mountd/rpc_samr.c index 446808b028e4..37a51f8110e7 100644 --- a/mountd/rpc_samr.c +++ b/mountd/rpc_samr.c @@ -1041,8 +1041,10 @@ int rpc_samr_init(void) return -ENOMEM; domain_name = g_ascii_strup(hostname, strlen(hostname)); - rpc_samr_add_domain_entry(domain_name); - rpc_samr_add_domain_entry("Builtin"); + if (rpc_samr_add_domain_entry(domain_name)) + return -ENOMEM; + if (rpc_samr_add_domain_entry("Builtin")) + return -ENOMEM; g_rw_lock_init(&ch_table_lock); return 0; } -- 2.25.1