From 044699ac5f688111747dbf021570a1602834a4cf Mon Sep 17 00:00:00 2001 From: Namjae Jeon Date: Thu, 6 Apr 2023 21:44:47 +0900 Subject: [PATCH 1/4] ksmbd-tools: fix NULL pointer dereference in samr_query_security_return() Fix NULL pointer dereference in samr_query_security_return(). Reported-by: zdi-disclosures@trendmicro.com # ZDI-CAN-17821 Signed-off-by: Namjae Jeon --- mountd/rpc_samr.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/mountd/rpc_samr.c b/mountd/rpc_samr.c index 37a51f8110e7..7887155aefc7 100644 --- a/mountd/rpc_samr.c +++ b/mountd/rpc_samr.c @@ -731,6 +731,9 @@ static int samr_query_security_return(struct ksmbd_rpc_pipe *pipe) if (!ch) return KSMBD_RPC_EBAD_FID; + if (!ch->user) + return KSMBD_RPC_EBAD_FID; + curr_offset = dce->offset; dce->offset += 16; if (build_sec_desc(dce, &sec_desc_len, ch->user->uid)) -- 2.34.1