From a21ca6e7b93109b69fe52ea240a1b17ce4816d37 Mon Sep 17 00:00:00 2001 From: Marios Makassikis Date: Sun, 6 Nov 2022 22:23:59 +0100 Subject: [PATCH 11/17] ksmbd-tools: mountd: fix potential null-ptr-deref ndr_read_uniq_vstring_ptr can set username->ptr to NULL, which will crash strstr() Signed-off-by: Marios Makassikis --- mountd/rpc_lsarpc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/mountd/rpc_lsarpc.c b/mountd/rpc_lsarpc.c index 79dd6bb942e9..46a4cc824b5b 100644 --- a/mountd/rpc_lsarpc.c +++ b/mountd/rpc_lsarpc.c @@ -385,7 +385,7 @@ static int lsarpc_lookup_names3_invoke(struct ksmbd_rpc_pipe *pipe) goto fail; if (ndr_read_uniq_vstring_ptr(dce, &username)) goto fail; - if (strstr(STR_VAL(username), "\\")) { + if (STR_VAL(username) && strstr(STR_VAL(username), "\\")) { strtok(STR_VAL(username), "\\"); name = strtok(NULL, "\\"); } -- 2.25.1